allow MP3StorageStyle.fetch() to fallback to url attribute #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2025
|
This looks like a more general issue affecting everything in 4.3.1 of the spec The proposed fix will probably work, but it feels a bit hacky. What do you think about instead adding a comment and checking explicitly for the frame type? In this case, checking for a UrlFrame should be sufficient. Do you have ideas on how we could test this to make sure it behaves as expected? And apologies for the long delay, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue Neurrone/beets-audible#71 we get a crash if the "WOAF" element does not have an "text" but an "url" attribute.
I added a fallback to also use the "url" attribute on
MP3StorageStyle.fetch().But I'm not an mp3 expert at all - please double check (maybe additional changes at other places are required).